Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new dotty version #569

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Support new dotty version #569

merged 1 commit into from
Mar 11, 2019

Conversation

molikto
Copy link
Contributor

@molikto molikto commented Mar 8, 2019

No description provided.

lefou
lefou reviewed Mar 10, 2019
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I can't see, what this has to do with a new dotty version. Isn't it more about better handling of Java source files?

@molikto
Copy link
Contributor Author

molikto commented Mar 11, 2019

@lefou the new dotty version bridge is in Java. I think they are in Scala before, so this code didn't work on new dotty version

@lefou lefou merged commit 981c4e1 into com-lihaoyi:master Mar 11, 2019
@smarter smarter mentioned this pull request Mar 17, 2019
Merged
@lefou lefou mentioned this pull request Apr 11, 2019
Closed
@biboudis biboudis mentioned this pull request Apr 14, 2019
Closed
20 tasks
@lefou lefou added this to the master milestone Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.8
Development

Successfully merging this pull request may close these issues.
2 participants
@molikto @lefou